Skip to content

Stop test_cli_save_html from writing into the repo root #583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vishal-tambi wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −1
Open

Stop test_cli_save_html from writing into the repo root #583

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion tests/test_cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -672,9 +672,17 @@ def test_cli_save_html(tmp_path: Path):
"""Test `save-html` command."""
base_command = "-i {VIDEO} -s {STATS} time {TIME} {DETECTOR} {COMMAND}"
assert invoke_scenedetect(base_command, COMMAND="save-html", output_dir=tmp_path) == 0
# `save-html --no-images` ignores -o, so pass an absolute filename to keep output in tmp_path.
no_images_html = tmp_path / "no-images.html"
assert (
invoke_scenedetect(base_command, COMMAND="save-html --no-images", output_dir=tmp_path) == 0
invoke_scenedetect(
base_command,
COMMAND=f"save-html --no-images --filename {no_images_html}",
output_dir=tmp_path,
)
== 0
)
assert no_images_html.exists()
# Ensure we can still call the now deprecated export-html command.
assert invoke_scenedetect(base_command, COMMAND="export-html", output_dir=tmp_path) == 0
# TODO: Check for existence of HTML & image files.
Expand Down