Repository navigation
refactor(@angular/build): add deleteFilesFromDisk utility and rename emit-files-to-disk - #34341
Merged
Merged
Conversation
…emit-files-to-disk Rename 'emit-files-to-disk.ts' to 'disk-files.ts' and introduce 'deleteFilesFromDisk' to delete removed output files with bounded concurrency.
alan-agius4
added
action: review
alan-agius4
marked this pull request as ready for review
October 14, 2026 09:38
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request consolidates disk file operations by renaming emit-files-to-disk.ts to disk-files.ts and introducing a new deleteFilesFromDisk utility to handle file deletions with bounded concurrency. The inline deletion logic in the application builder has been refactored to use this new utility. Feedback suggests restoring the maxRetries: 3 option in the file deletion logic to prevent flaky failures on environments like Windows where files might be temporarily locked.
clydin
approved these changes
Oct 14, 2026
alan-agius4
added
action: merge
Collaborator
Author
|
This PR was merged into the repository. The changes were merged into the following branches:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename
emit-files-to-disk.tstodisk-files.tsand introducedeleteFilesFromDiskto delete removed output files with bounded concurrency.Related to #34340.