Repository navigation
Remove shehu from TITLES: a Hausa given name, not a leading title - #674
Merged
Merged
Conversation
`shehu` arrived with an early bulk import (1a51555) and was never put to decisions.md#vocabulary-collisions C-i. It fails C-i where the title claim acts: `Shehu Shagari` read title Shehu, family Shagari in every release from 1.4.0 through 2.4.1, and now reads given Shehu. Three CLDR corpus names move, all toward CLDR's reading, and they leave cldr_agreement.json. The Excluded (TITLES) entry records the counts and the accepted cost (the honorific use reads as a given name). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Review: the entry asserted Shehu leads a name, but its only leading-position count (1 Wikidata bearer) sits below herra's ~670, which the graf class accepted. Cite the evidence that does carry it: CLDR's six Hausa renderings file Shehu as the given name. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #674 +/- ##
=======================================
Coverage 99.02% 99.02%
=======================================
Files 46 46
Lines 4534 4534
=======================================
Hits 4490 4490
Misses 44 44 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #660.
shehuhas been inTITLESsince an early bulk import (1a51555f) and was never checked againstdecisions.md#vocabulary-collisionsC-i. It fails C-i in the leading position, which is where the title claim acts:Changes
nameparser/config/titles.py: removesshehu.docs/design/decisions.md: adds anExcluded (TITLES)entry with the counts fromtools/name_usage.py shehuand the accepted cost (Shehu Abubakar, written as honorific plus name, reads given Shehu). The entry doesn't count leading-position use; it grounds the exclusion in CLDR's Hausa sample data, which files Shehu as the given name in all six renderings that contain it.docs/release_log.rst: adds a Fix bullet under Unreleased. If this ships as 2.4.2, move it into that entry.tools/name_usage.py: the docstring now says "a title untilShehu ShagarireadsShehuas a title:shehuis a common Hausa given name and an Albanian surname #660".Measured
uv run python tools/differential/snapshot.py --since v2.4.1lists 3 moved names, all held only bycorpus_cldr.jsonl:Shehu Muhammed,Muhammed, ShehuandModibbo, Shehu Bello. All three now agree with CLDR on every role and leavecldr_agreement.json. The JA locale rows were carried over unchanged (namedivider isn't installed locally). The 1.4.0 through 2.4.1 reading was checked on every released wheel.No case row is added: it would pin a wordlist entry, not a fork, and the snapshot already holds the moved names.
Full suite passes without namedivider, matching CI's build jobs. mypy and ruff are clean. The design-docs review raised one point: the reason given for keeping shehu out of the graf class was asserted rather than measured. It is fixed in the second commit.
🤖 Generated with Claude Code