Skip to content

Remove shehu from TITLES: a Hausa given name, not a leading title - #674

Merged
derek73 merged 2 commits into
masterfrom
fix/issue-660-shehu-title
Oct 13, 2026
Merged

derek73 merged 2 commits into
masterfrom
fix/issue-660-shehu-title

Conversation

@derek73

@derek73 derek73 commented Oct 13, 2026

Copy link
Copy Markdown
Owner

Closes #660.

shehu has been in TITLES since an early bulk import (1a51555f) and was never checked against decisions.md#vocabulary-collisions C-i. It fails C-i in the leading position, which is where the title claim acts:

Shehu Shagari   1.4.0 – 2.4.1: title 'Shehu', family 'Shagari'
                this PR:       given 'Shehu', family 'Shagari'

Changes

  • nameparser/config/titles.py: removes shehu.
  • docs/design/decisions.md: adds an Excluded (TITLES) entry with the counts from tools/name_usage.py shehu and the accepted cost (Shehu Abubakar, written as honorific plus name, reads given Shehu). The entry doesn't count leading-position use; it grounds the exclusion in CLDR's Hausa sample data, which files Shehu as the given name in all six renderings that contain it.
  • docs/release_log.rst: adds a Fix bullet under Unreleased. If this ships as 2.4.2, move it into that entry.
  • tools/name_usage.py: the docstring now says "a title until Shehu Shagari reads Shehu as a title: shehu is a common Hausa given name and an Albanian surname #660".

Measured

uv run python tools/differential/snapshot.py --since v2.4.1 lists 3 moved names, all held only by corpus_cldr.jsonl: Shehu Muhammed, Muhammed, Shehu and Modibbo, Shehu Bello. All three now agree with CLDR on every role and leave cldr_agreement.json. The JA locale rows were carried over unchanged (namedivider isn't installed locally). The 1.4.0 through 2.4.1 reading was checked on every released wheel.

No case row is added: it would pin a wordlist entry, not a fork, and the snapshot already holds the moved names.

Full suite passes without namedivider, matching CI's build jobs. mypy and ruff are clean. The design-docs review raised one point: the reason given for keeping shehu out of the graf class was asserted rather than measured. It is fixed in the second commit.

🤖 Generated with Claude Code

derek73 and others added 2 commits October 13, 2026 02:43
`shehu` arrived with an early bulk import (1a51555) and was never put
to decisions.md#vocabulary-collisions C-i. It fails C-i where the title
claim acts: `Shehu Shagari` read title Shehu, family Shagari in every
release from 1.4.0 through 2.4.1, and now reads given Shehu.

Three CLDR corpus names move, all toward CLDR's reading, and they leave
cldr_agreement.json. The Excluded (TITLES) entry records the counts and
the accepted cost (the honorific use reads as a given name).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Review: the entry asserted Shehu leads a name, but its only leading-position
count (1 Wikidata bearer) sits below herra's ~670, which the graf class
accepted. Cite the evidence that does carry it: CLDR's six Hausa renderings
file Shehu as the given name.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@derek73 derek73 added the bug label Oct 13, 2026
@derek73 derek73 self-assigned this Oct 13, 2026
@codecov

codecov Bot commented Oct 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.02%. Comparing base (affabb9) to head (66a9489).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #674   +/-   ##
=======================================
  Coverage   99.02%   99.02%           
=======================================
  Files          46       46           
  Lines        4534     4534           
=======================================
  Hits         4490     4490           
  Misses         44       44           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@derek73
derek73 merged commit f9b2b81 into master Oct 13, 2026
12 checks passed
@derek73
derek73 deleted the fix/issue-660-shehu-title branch October 13, 2026 09:51
@derek73 derek73 added this to the 2.4.2 milestone Oct 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Shehu Shagari reads Shehu as a title: shehu is a common Hausa given name and an Albanian surname

1 participant