Repository navigation
Report the given/middle split where a source states it - #703
Merged
Merged
Conversation
CLDR and the conventions table state given and given2, but the merged given_names role passes a parse that splits them wrongly (Kim Min Ho). Add a report-only view counting those renderings, listed with --split. Not ratcheted: what middle means for a compound given name is open. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Test the merged-disagreement and patronymic skips, the exact source set and the --split listing; document --split and that the report mixes compound given names with given2-before-given order swaps. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #703 +/- ##
=======================================
Coverage 99.03% 99.03%
=======================================
Files 46 46
Lines 4541 4541
=======================================
Hits 4497 4497
Misses 44 44 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #702.
Adds a report-only view to
cldr_agreement.pyfor the sources that state the split (CLDR'sgiven2, the conventions table): renderings whose mergedgiven_namesagrees but whosegiven/middlesplit differs.--splitlists them. GND and Wikidata are never scored on it.Measured: 265 CLDR and 3 conventions renderings, matching the issue. Not ratcheted yet, since what
middlemeans for compound given names is still open, so #702 stays open.🤖 Generated with Claude Code