Repository navigation
Add owura and bapak to TITLES (#662) - #705
Merged
Merged
Conversation
Akan and Indonesian Mr. were read as the given name ("Bapak Dwi Putro"
gave given 'Bapak'). Neither has a census or Wikidata bearer. Hausa malam
is excluded on the shehu precedent (#660): a US surname with a Nigerian
given-name bearer, recorded in decisions.md#salutation-titles beside bay.
Two CLDR corpus names move, both toward CLDR's fields.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
#662) Review of 0cfa78c: owura had no case row, the Greve-style contrast rows were missing, and the decisions entry said Hausa uses Malam as a given name when CLDR's Hausa data files it as the title. The entry now says malam is declined on the lower-bound given-name counts, moves malam and bay into the Excluded (TITLES) block, and carries a measurement recipe. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #705 +/- ##
=======================================
Coverage 99.03% 99.03%
=======================================
Files 46 46
Lines 4541 4541
=======================================
Hits 4497 4497
Misses 44 44 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
derek73
added a commit
that referenced
this pull request
Oct 17, 2026
#705 listed bapak, and the CLDR id rendering 'Bapak Adinata, Dwi Putro bin MP' now peels it before the family comma. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
derek73
added a commit
that referenced
this pull request
Oct 18, 2026
* Peel a title written before a family comma into the title `Dr. Smith, John` read family 'Dr. Smith' in every release from 1.4.0 through 2.4.2. A run of listed title words opening the part before a family comma now goes to `title` (rules.md#H6): vocabulary only, so `Xyz. Smith, John` keeps its family; it stops at a word that is a particle too (`St Pierre`, `Freiherr von Berg`) and where nothing but post-nominals stands behind it (H3's floor: `MD PhD Jr., John`), and it leaves the family its last word. Amends H1, H2, H3 and C1's Accepted clauses, qualifies C1, S2 and W3, adds decisions.md#H6 with the measurements, and re-records the snapshot (20 corpus moves, all a title leaving the family) and the CLDR agreement (29 fields now agree, 28 closer, none regress). Closes #701 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Record the Bapak listing's move under H6 after merging master #705 listed bapak, and the CLDR id rendering 'Bapak Adinata, Dwi Putro bin MP' now peels it before the family comma. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Address the PR review of #701: gov, wording, missing rows - Add gov to TITLES (Derek): `Lt. Gov. Smith, John` split the compound across title and family, the run being vocabulary-only. 236 US Census surname bearers; recorded in decisions.md#H6. - Keep `Dr. PhD Smith, John` at family 'PhD Smith' (Derek), and say in the comment that the run's first leftover piece is family. - H6's Accepted clause names the particle stop, not the 1919 surname argument, as what keeps Freiherr; Graf peels (example added). - Wording: H6 "or" and "at least one word", H3 "one word", H1 "name word", W3's H6 sentence, AGENTS.md's stop description and its #701 lesson as its own sentence, usage.rst's bullet, the release log. - Rows: joined title units, Lt. Gov., Dr. King, a FAMILY_FIRST_GIVEN_LAST twin, bare Gov. - Move the H6 block above the P2 comment it interrupted. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Point decisions.md#H6 at #709, the German-ranks question Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Correct decisions.md#H6: 1.4.0 reads Dr. PhD Smith, John as master did The branch's family 'PhD Smith' matches 1.4.0 only for the untitled 'PhD Smith, John'; 1.4.0 gave the titled form family 'Dr. Smith', suffix 'PhD' (the fix-commit review, checked against the wheel). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Say why H6's run is not leading_titles, and why the length test leads The /simplify review found the comment's 'H3's floor' invited swapping in leading_titles, whose one-word give-back reads 'MD PhD Jr.' with title 'MD'. Comment-only: frames and the snapshot are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Take the two frame savings the /simplify review found An inline tag test ahead of is_title_piece leaves a family part no title opens free of frames (Smith Jones, John back to master's 203), and the family loop no longer re-asks a piece the floor walk already proved a suffix (Dr. Smith + 20 PhD, John 924 -> 904). No reading moved on an 88,740-head grid under two orders; the snapshot matches. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #662.
Bapak Dwi Putroread givenBapak; it now reads titleBapak, givenDwi, familyPutro. LikewiseOwura Kwame Mensah(Akan Mr.). Checked against the 1.4.0, 2.0.0 and 2.4.2 wheels: all three give firstBapak, middleDwi.owuraandbapakjoinTITLES. Each has under 100 US Census bearers and none found on Wikidata (tools/name_usage.py).malam(Hausa) andbay(Turkish), recorded indecisions.md's Excluded (TITLES) block.malamis a US surname with a lower-bound Nigerian given-name bearer;bayfails C-i on its Hungarian bearers. Note CLDR's Hausa data files Malam as a title, so themalamcall is on the counts, not theshehuprecedent.snapshot.jsonlandcldr_agreement.jsonre-recorded)./pr-review-toolkit:review-prran code, test and comment reviews; the second commit applies their findings.🤖 Generated with Claude Code