Repository navigation
feat(deno): Add incoming request options to denoServeIntegration - #25493
Merged
isaacs merged 4 commits intoOct 19, 2026
Conversation
isaacs
added this pull request to stack #25494
October 18, 2026 22:56
isaacs
requested review from
JPeer264 and
mydea
and removed request for
a team
October 18, 2026 22:56
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
JPeer264
approved these changes
Oct 19, 2026
isaacs
requested review from
logaretm and
s1gr1d
and removed request for
a team
October 19, 2026 16:47
|
This PR is too large for Bugbot to review. It changes 75,966 lines and 3,735,756 characters. Split the change into smaller pull requests to get a review. |
isaacs
force-pushed
the
isaacschlueter/js-3955-deno-denoserveintegration-lacks-the-incoming-request-options
branch
from
October 19, 2026 16:57
096f910 to
334851d
Compare
isaacs
force-pushed
the
isaacschlueter/js-3955-deno-denoserveintegration-lacks-the-incoming-request-options
branch
from
October 19, 2026 17:41
334851d to
bbc79aa
Compare
Base automatically changed from
isaacschlueter/js-3522-denos-export-surface-is-narrower-than-cloudflares
to
develop
October 19, 2026 18:49
isaacs
force-pushed
the
isaacschlueter/js-3955-deno-denoserveintegration-lacks-the-incoming-request-options
branch
from
October 19, 2026 18:50
4defd67 to
f7e6b65
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit f7e6b65. Configure here.
`Deno.serve` is the server most Deno apps use, but its integration only took `maxRequestBodySize` and the deprecated `ignoreStatusCodes`. A user could not skip body capture for one route, such as a health check, an upload, or a route that receives secrets. `denoHttpIntegration`, Node and Cloudflare all allow this. `denoServeIntegration` now accepts `ignoreRequestBody`, `ignoreIncomingRequests`, `ignoreStaticAssets`, `spans`, `onSpanCreated` and `onSpanEnd`. They use the same names and behavior as `denoHttpIntegration`, but the callbacks receive the web `Request`. The options follow core's `node:http` server code. `urlPath` includes the query string, and the static asset filter applies only to `GET`. When the SDK skips a span, it still continues the incoming trace, attaches request data and the body, and captures errors. For a streamed response, `onSpanEnd` runs when the stream finishes. It does not run when the handler throws, because there is no `Response` to pass. Two defaults change behavior. `ignoreStaticAssets` defaults to `true`, so `GET` requests for files such as `favicon.ico` or `*.js` no longer create spans. `spans` defaults to the client's tracing configuration, so the integration no longer starts spans when tracing is disabled. Request sessions for `Deno.serve` and the same options for `Bun.serve` remain separate work. Fixes #25492 Fixes JS-3955 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
isaacs
force-pushed
the
isaacschlueter/js-3955-deno-denoserveintegration-lacks-the-incoming-request-options
branch
from
October 19, 2026 19:06
258afa8 to
9b230da
Compare
isaacs
deleted the
isaacschlueter/js-3955-deno-denoserveintegration-lacks-the-incoming-request-options
branch
October 19, 2026 20:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deno.serveis the server most Deno apps use, but its integration only tookmaxRequestBodySizeand the deprecatedignoreStatusCodes. A user could not skip body capture for one route, such as a health check, an upload, or a route that receives secrets.denoHttpIntegration, Node and Cloudflare all allow this.denoServeIntegrationnow acceptsignoreRequestBody,ignoreIncomingRequests,ignoreStaticAssets,spans,onSpanCreatedandonSpanEnd. They use the same names and behavior asdenoHttpIntegration, but the callbacks receive the webRequest.The options follow core's
node:httpserver code.urlPathincludes the query string, and the static asset filter applies only toGET. When the SDK skips a span, it still continues the incoming trace, attaches request data and the body, and captures errors. For a streamed response,onSpanEndruns when the stream finishes. It does not run when the handler throws, because there is noResponseto pass.Two defaults change behavior.
ignoreStaticAssetsdefaults totrue, soGETrequests for files such asfavicon.icoor*.jsno longer create spans.spansdefaults to the client's tracing configuration, so the integration no longer starts spans when tracing is disabled.Request sessions for
Deno.serveand the same options forBun.serveremain separate work.Fixes #25492
Fixes JS-3955