Repository navigation
Conversation
s1gr1d
added this pull request to stack #25525
October 19, 2026 13:34
Base automatically changed from
jp/react-router-orchestrion-core-default-import
to
develop
October 19, 2026 16:07
…ackages on Vite 8 Rolldown emits a require() of an external package in bundled CommonJS as __require(), which a bundler that runs over the server output cannot follow. On Rolldown, the orchestrion Vite plugin now also force-bundles the dependencies that the CommonJS code of instrumented packages requires. Fixes #25470
JPeer264
force-pushed
the
sigridhuemer/js-3951-sveltekit-3-sentry-118-build-time-instrumentation-breaks
branch
from
October 19, 2026 16:07
2286e1b to
bfe4ef2
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Vite 8, Rolldown emits a
require()of an external package in bundled CommonJS as__require(). Adapters that bundle the server output again (Nitro, the Azure SWA adapter) can't follow it, sopg-typesand similar packages go missing at runtime. Vite 7 emitted static imports instead.On Rolldown only, the plugin now also bundles the
dependenciesthat instrumented CommonJS requires. Optional and peer dependencies stay external. We didn't useesmExternalRequirePlugin, because it turns function-exported CommonJS into objects on Node < 23. The bug needs a flatnode_modules, hence the new hoisted E2E variant.Stacked on #25359.
Fixes #25470