Skip to content

feat: Export the Node bundler plugins from SDKs that wrap @sentry/node - #25536

Open
timfish wants to merge 2 commits into
developfrom
feat/reexport-node-bundler-plugins
Open

timfish wants to merge 2 commits into
developfrom
feat/reexport-node-bundler-plugins

Conversation

@timfish

@timfish timfish commented Oct 19, 2026 •

Copy link
Copy Markdown
Collaborator

Adds the /vite, /rollup, /webpack and /esbuild entry points from @sentry/node to @sentry/nestjs, @sentry/aws-serverless, @sentry/google-cloud-serverless and @sentry/hono (under /node/*). Each entry re-exports the @sentry/node plugin, so users no longer need @sentry/bundler-plugins as an extra dependency.

@sentry/effect is left out, since its builds also target the browser.

Fixes #25522

@timfish
timfish marked this pull request as ready for review October 19, 2026 15:45
@timfish
timfish requested review from a team as code owners October 19, 2026 15:45
@timfish
timfish requested review from JPeer264, chargome, mydea and s1gr1d and removed request for a team October 19, 2026 15:45

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit e8374ad. Configure here.

Comment thread packages/nestjs/test/bundler-plugin.test.ts
"default": "./build/cjs/index.deno.js"
}
},
"./node/vite": {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

l: Hono might be deprecated, so we could leave that out I guess. And if we would keep it we might need a ./cloudflare/vite export too

"default": "./build/npm/cjs/awslambda-auto.js"
}
},
"./vite": {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

q: Is it common to have bundlers in front of AWS lambdas? I thought they're always quite plain when it comes to bundlers (same for Google)

"default": "./build/cjs/setup.js"
}
},
"./vite": {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

m: I did a quick research and it does seem that NestJS only uses webpack. I also saw that this can be extended, but this is not really in their docs, but only in one of their examples: https://github.com/nestjs/nest/blob/master/sample/08-webpack/webpack-hmr.config.cjs

This is a tldr of the clanker:

The Nest CLI has three builders. You set the builder with compilerOptions.builder in nest-cli.json:

  • tsc: This is the default. It does not make a bundle.
  • webpack: This makes a bundle. It is the default only in monorepo mode ("monorepo": true). You can also select it with "webpack": true or nest build --webpack.
  • swc: This compiles files and does not make a bundle. You select it with "builder": "swc" or nest start -b swc.

And before we export one of these we should check if it works via an E2E test

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Re-export Node bundler plugins from server SDKs that wrap @sentry/node

2 participants