Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create's a C/C++ quality query suite
cpp-code-quality.qls. Technically this already existed, as didcpp-code-quality-extended.qls, but they didn't have any queries in them. This pull request tags 45 appropriate and tested queries withqualityto populate the suites (... in fact a single query did get added incidentally with thequalitytag a few weeks ago -cpp/ambiguous-assignment-of-comparison- that's preserved as well, for a total of 46 queries).In addition some of the sub-tags have been updated, so that each
qualityquery has eithermaintainabilityorreliability(exactly one required), and in many cases other descriptive sub-tags have been added / updated as well (these are optional).The existing / older
cpp-security-and-quality.qlssuite has been "frozen" so that these and future tag changes don't affect what queries are in there (to be more precise, the quality half of the suite is frozen to a fixed list of queries matching the non-security queries in it before this pull request, while the security queries in it are still picked algorithmically; this is the same approach as was taken in Java and I believe other languages).Draft PR, pending discussion with interested parties.