Repository navigation
Last argument to field resolver is not checked when using the context class schema parser option #418
Description
To reproduce:
SchemaParserOptions options = SchemaParserOptions.newOptions()
.contextClass(CustomContext.class)
.build();type Mutation {
myMutation(
id: ID!
field: String!
persist: Boolean!
): Entity
}The following method field resolver is accepted:
public Entity myMutation(String id, String field, CustomContext context)Although it is missing the persist parameter. This is because the CustomContext type is accepted as the last parameter.
Ideally this should throw just like in the case where DataFetchingEnvironment is used as the last parameter.
Not sure if it's possible.
Activity
oryan-block commentedon Oct 18, 2026
Same problem without
contextClass. TheDataFetchingEnvironmentcase isn't checked either when the parameter counts match. This builds without a warning:The method has as many parameters as the field has arguments, so
FieldResolverScanner#verifyMethodArgumentsaccepts it andfirstgets mapped ontoenv. Every query ofusersthen fails, withParameter specified as non-null is null: ... parameter envwhenfirstis omitted, andCannot construct instance of graphql.schema.DataFetchingEnvironmentwhen it's sent.Found by the every-field check in #879 (
DeprecatedDirectiveTest's fixtures had this).Since these schemas build today, I think the fix is a WARN at build that names the field and the parameter, then throwing in 15.0.0.