Skip to content

Run the Version Release PR checks through GitHub's workflow approval - #877

Merged
oryan-block merged 3 commits into
masterfrom
build/version-release-checks
Oct 18, 2026
Merged

oryan-block merged 3 commits into
masterfrom
build/version-release-checks

Conversation

@oryan-block

@oryan-block oryan-block commented Oct 18, 2026 •

Copy link
Copy Markdown
Collaborator

Fixes #876

Checklist

  • Pull requests follows the contribution guide
  • New or modified functionality is covered by tests

Description

The Version Release PR still needed an admin merge on #873. The workflow_dispatch from #872 ran the checks on the PR's head commit, but GitHub doesn't link those runs to the PR, so the required build (N) checks never showed up on it.

A PR opened with GITHUB_TOKEN already gets its pull_request runs, they just wait for someone with write access to select Approve workflows to run in the merge box (docs). That's GitHub's intended way for this. So I removed the dispatch step, the actions: write it needed and the workflow_dispatch trigger on pull-request.yml. GitHub shows that button in the PR's merge box, so once the runs are approved the PR should merge like any other.

Options I didn't go with:

  • A GitHub App token or a PAT. GitHub suggests these when the runs should start without approval, but both need new secrets, and the app needs an org app too. The approval is one more click on a PR that needs a review anyway.
  • Posting build (N) statuses or check runs from the release workflow. That fakes the required checks instead of running them.
  • Approving the run from the workflow with POST /actions/runs/{id}/approve. It's only documented for fork PRs from first-time contributors, and it would defeat the point of the approval.

actionlint passes. Whether the approved runs count can only be checked on the next release, since runs only wait for approval when the workflow opens or updates the PR. I'll update the "Releasing a version" wiki page after this merges.

🤖 Generated with Claude Code

@sonarqubecloud

Copy link
Copy Markdown

@oryan-block
oryan-block merged commit 7205867 into master Oct 18, 2026
7 checks passed
@oryan-block
oryan-block deleted the build/version-release-checks branch October 18, 2026 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The Version Release PR still needs an admin merge

1 participant