Skip to content

tools: add --error-on-warn configure flag in test-shared.yml - #66751

Open
aduh95 wants to merge 3 commits into
nodejs:mainfrom
aduh95:error-on-warn
Open

aduh95 wants to merge 3 commits into
nodejs:mainfrom
aduh95:error-on-warn

Conversation

@aduh95

@aduh95 aduh95 commented Oct 15, 2026

Copy link
Copy Markdown
Contributor

Given that this workflow compiles V8 and other libs separately, that would allow us to detect any Node.js-specific warning that needs to be addressed.

Given that this workflow compiles V8 and other libs separately, that
would allow us to detect any Node.js-specific warning that needs to be
addressed.

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Oct 15, 2026
@panva

panva commented Oct 15, 2026 •

Copy link
Copy Markdown
Member

we better wait to have openssl 3.0 and 1.1 back in the matrix (#66711) and passing before proceeding here

@aduh95

aduh95 commented Oct 15, 2026

Copy link
Copy Markdown
Contributor Author

Blocked on #66752

@aduh95 aduh95 added blocked PRs that are blocked by other issues or PRs. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. dont-land-on-v26.x PRs that should not land on the v26.x-staging branch and should not be released in v26.x. labels Oct 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocked PRs that are blocked by other issues or PRs. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. dont-land-on-v26.x PRs that should not land on the v26.x-staging branch and should not be released in v26.x. tools Issues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants