Repository navigation
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 19.30% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 57 functions across 11 files. (2 skipped:… | Write docstrings for the functions missing them to satisfy the coverage threshold. |
-
Check name Status Explanation Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title clearly and concisely describes the main changes: adding a builder for GenericRetryand deprecating mutable setters.
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 19.30% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 57 functions across 11 files. (2 skipped: 2 unsupported.)
- Fix all pre-merge checks with AI
✨ Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Static review found no blocking issues, with existing retry behavior preserved and focused builder coverage added; tests were not executed.
0 open findings
What changed in this PR
Refactors GenericRetry toward builder-based configuration while preserving existing retry behavior and annotation support.
Changes:
- Adds a builder,
toBuilder(), and diagnostictoString(); deprecates mutable configuration methods. - Migrates configuration loading, tests, and documentation to the builder API.
- Adds tests for builder defaults, configuration copying, and independent instances.
| File | Description |
|---|---|
| operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/triggerallevent/eventing/TriggerReconcilerOnAllEventIT.java | Migrates event-trigger retry setup. |
| operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/retry/RetryMaxAttemptIT.java | Migrates retry-limit setup. |
| operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/retry/RetryIT.java | Migrates retry setup. |
| operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/retry/RetryIntervalHonoredOnFrequentEventsIT.java | Migrates retry-interval setup. |
| operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/errorstatushandler/ErrorStatusHandlerIT.java | Migrates error-handler retry setup. |
| operator-framework/src/main/java/io/javaoperatorsdk/operator/config/loader/ConfigLoader.java | Builds retries from loaded configuration. |
| operator-framework-core/src/test/java/io/javaoperatorsdk/operator/processing/retry/GenericRetryTest.java | Adds builder and factory coverage. |
| operator-framework-core/src/test/java/io/javaoperatorsdk/operator/processing/retry/GenericRetryExecutionTest.java | Migrates retry-execution fixtures. |
| operator-framework-core/src/test/java/io/javaoperatorsdk/operator/processing/event/ReconciliationDispatcherTest.java | Migrates zero-retry configuration. |
| operator-framework-core/src/test/java/io/javaoperatorsdk/operator/processing/event/EventProcessorTest.java | Migrates event-processing retry fixtures. |
| operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/retry/GenericRetry.java | Introduces builder API and deprecates mutators. |
| docs/content/en/docs/documentation/testing.md | Updates the testing example. |
| docs/content/en/docs/documentation/error-handling-retries.md | Documents builder usage and deprecation plans. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
TQJADE
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a builder for
GenericRetryas a non-breaking first step towardsmaking it immutable in v6. The mutating methods are deprecated for
removal, so users can migrate now and the setters can be dropped in the
next major version. More: #2935
Summary by CodeRabbit
New Features
Documentation