Skip to content

Render hover labels through MathJax when the whole label is one tex expression #8051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SergeyAxiomatic wants to merge 7 commits into
base: main
Choose a base branch
from
+904 −294
Open

Render hover labels through MathJax when the whole label is one tex expression #8051

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
29200a1
Render hover labels through MathJax when the whole label is one tex e…
SergeyAxiomatic Sep 17, 2026
4ef0e75
Fix the draftlog filename and link for PR #8051
SergeyAxiomatic Sep 17, 2026
704815a
Fix the new hover MathJax tests, not the reviewed fix itself
SergeyAxiomatic Sep 17, 2026
1e8ef5f
Address review: fix Fx.loneHover, share the math positioning code, ad…
SergeyAxiomatic Sep 18, 2026
39d42e4
Sanitize javascript: urls MathJax's \href macro can inject
SergeyAxiomatic Sep 18, 2026
dd5e7c7
Add XSS regression tests for annotations and legend text
SergeyAxiomatic Sep 21, 2026
f1e960d
Address review: clear data-notex for pure-tex unified hover rows
SergeyAxiomatic Oct 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions draftlogs/8051_fix.md
View file
Open in desktop

@KoolADE85 KoolADE85 Oct 8, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also include a brief one-liner that mentions the XSS fix here.

Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- Fix hover labels ignoring MathJax for text that is a single tex expression [[#8051](https://github.com/plotly/plotly.js/pull/8051)]
- Fix XSS via `javascript:` URLs in MathJax `\href` macros by sanitizing links in MathJax-rendered text [[#8051](https://github.com/plotly/plotly.js/pull/8051)]
Loading