Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions draftlogs/8125_fix.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- Fix normalization of `contours.value` for interval constraints in `contour` and `contourcarpet` [[#8125](https://github.com/plotly/plotly.js/pull/8125)]
6 changes: 3 additions & 3 deletions src/traces/contour/constraint_defaults.js
Original file line number Diff line number Diff line change
Expand Up @@ -57,10 +57,10 @@ function handleConstraintValueDefaults(coerce, contours) {
contours.value = [zvalue, zvalue + 1];
}
} else if(contours.value.length > 2) {
contours.value = contours.value.slice(2);
} else if(contours.length === 0) {
contours.value = contours.value.slice(0, 2);
} else if(contours.value.length === 0) {
contours.value = [0, 1];
} else if(contours.length < 2) {
} else if(contours.value.length < 2) {
zvalue = parseFloat(contours.value[0]);
contours.value = [zvalue, zvalue + 1];
} else {
Expand Down
39 changes: 39 additions & 0 deletions test/jasmine/tests/contour_test.js
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,45 @@ describe('contour defaults', function() {
expect(traceOut.xcalendar).toBe('coptic');
expect(traceOut.ycalendar).toBe('ethiopian');
});

it('should coerce constraint interval values to two numbers', function() {
var specs = [
{
value: [],
expected: [0, 1]
},
{
value: [5],
expected: [5, 6]
},
{
value: [10, 20],
expected: [10, 20]
},
{
value: [10, 20, 30],
expected: [10, 20]
}
];

specs.forEach(function(spec) {
traceIn = {
type: 'contour',
z: [[0, 1], [2, 3]],
contours: {
type: 'constraint',
operation: '[]',
value: spec.value
}
};

traceOut = {};

supplyDefaults(traceIn, traceOut, defaultColor, layout);

expect(traceOut.contours.value).toEqual(spec.expected);
});
});
});

describe('contour makeColorMap', function() {
Expand Down
Loading