Skip to content

Fix ternary.sum relayout recalculation #8128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Lexachoc wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix ternary.sum relayout recalculation #8128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8531b97
Update attrs.sum.editType to 'calc'
Lexachoc Oct 16, 2026
fbd0447
add draftlog
Lexachoc Oct 16, 2026
90fd479
fix typo in draftlog
Lexachoc Oct 16, 2026
3d8621d
update schema
Lexachoc Oct 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions draftlogs/8128_fix.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- Fix `ternary.sum` relayout to recalculate ternary trace data [[#8128](https://github.com/plotly/plotly.js/pull/8128)]
3 changes: 3 additions & 0 deletions src/plots/ternary/layout_attributes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,9 @@ var attrs = module.exports = overrideAll({
caxis: ternaryAxesAttrs
}, 'plot', 'from-root');

// ternary.sum is used by calc to normalize
attrs.sum.editType = 'calc';

// set uirevisions outside of `overrideAll` so we can get `editType: none`
attrs.uirevision = {
valType: 'any',
Expand Down
2 changes: 1 addition & 1 deletion test/plot-schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12427,7 +12427,7 @@
"sum": {
"description": "The number each triplet should sum to, and the maximum range of each axis",
"dflt": 1,
"editType": "plot",
"editType": "calc",
"min": 0,
"valType": "number"
},
Expand Down
Loading