Repository navigation
Conversation
…tton' into feat-ternary-toggle-spikeline-button
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #8041.
Similar to the Cartesian spikeline button (
toggleSpikelines), this adds atoggleTernarySpikelinesbutton to toggle the ternary spikelines implemented in #8041.I think this could be very useful.
IMHO, I find the current
toggleSpikelinesbehavior a bit confusing. When I first tried the button, I expected a "toggle" to simply control the visibility of the spikelines, ON or OFF.That is why
toggleTernarySpikelinesis designed this way: it hides the current ternary spikelines when turned off and restores their previous visibility states when turned back on.Reproduce with devtools
Open:
Then run in the console:
Screenshots
Note
While implementing this, I found a bug #8129, where modebar toggle buttons do not use the correct active icon color on initial render. A fix has been submitted in #8130.
Additional
Docs may also need to be updated to list
toggleTernarySpikelineson https://plotly.com/javascript/configuration-options/, https://plotly.com/python/configuration-options/, and possibly other related pages.