Repository navigation
gh-153569: Simplify tokenizer source views and reader ownership - #158849
Merged
Merged
Conversation
pablogsal
force-pushed
the
tokenizer-source-api-cleanup
branch
from
October 5, 2026 14:22
b516b52 to
723a678
Compare
pablogsal
force-pushed
the
tokenizer-source-api-cleanup
branch
from
October 5, 2026 15:51
f36c44b to
7da4c7f
Compare
pablogsal
force-pushed
the
tokenizer-source-api-cleanup
branch
from
October 5, 2026 16:11
7da4c7f to
ffb781d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move byte access, searches, and span views into the source API. Keep comment and trailing-statement scanning on offsets, copy formatted-string expression segments through span views, and use logical line spans for
_tokenizecolumn calculations.Move the borrowed file handle and owned encoding into the reader so input state and its cleanup live together. Reuse the codec helper to create incremental decoders.
Follow-up to #153569.