Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In 3.14,
Reader.calc_screen()sizes the wrap loop as(width_of_line + prompt) // console_widthrows, but each wrapped row only holdsconsole_width - 1characters because of the\marker. On long lines the loop ends early, so the tail of the line never reachesscreeninfo, and moving down to those rows raisesIndexErrorinmax_column(). For example, 19 characters at width 10 already lose the last one.The loop now runs until the whole line is placed. main and 3.15 don't have this bug, since gh-148105 rewrote the layout code there, so this PR targets 3.14 only. 3.13 has the same loop, so it could take this fix as well.