Repository navigation
[mypyc] Fix crash when '__enter__'/'__exit__' inherited from Python class - #22227
Merged
Merged
Conversation
…lass Fixes mypyc/mypyc#1193. Compiling a `with` statement crashed if the context manager was a native class that inherited `__enter__` or `__exit__` from a non-native class: ```python from contextlib import AbstractContextManager class C(AbstractContextManager): def __exit__(self, exc_type, exc_value, traceback) -> None: pass with C() as c: # KeyError: "'C' has no attribute '__enter__'" pass ``` Now the methods are only called natively if both are defined in a native class, and otherwise the generic code path is used.
p-sawicki
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes mypyc/mypyc#1193.
Compiling a
withstatement crashed if the context manager was a native class that inherited__enter__or__exit__from a non-native class:Now the methods are only called natively if both are defined in a native class.