Skip to content

ci(publish): push a commit-sha tag on supervisor builds from main - #5026

Merged
nicktrn merged 1 commit into
mainfrom
ci/supervisor-sha-tag-on-main
Oct 14, 2026
Merged

nicktrn merged 1 commit into
mainfrom
ci/supervisor-sha-tag-on-main

Conversation

@nicktrn

@nicktrn nicktrn commented Oct 14, 2026

Copy link
Copy Markdown
Collaborator

Summary

Supervisor images built from main are only published under the mutable main tag, so there is no way to pin a deployment to the exact commit a build came from. The webapp publish already pushes a full commit-sha tag next to main for this reason. This adds the same block to the supervisor publish, so every main build is also available as ghcr.io/triggerdotdev/supervisor:<sha>.

Tag builds (re2-*, build-*, v4.x.y) are unchanged.

Matches the webapp publish, which already pushes an immutable full-sha tag next to the mutable main tag so a build can be pinned by commit.
@nicktrn nicktrn self-assigned this Oct 14, 2026
@changeset-bot

changeset-bot Bot commented Oct 14, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: ba5e6fe

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 15fceb10-d0c7-497a-9a7a-a9dbc641969a
📥 Commits

Reviewing files that changed from the base of the PR and between 11436a3 and ba5e6fe.

📒 Files selected for processing: 1
  • .github/workflows/publish-worker-v4.yml

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout: 6
  • GitHub Check: code-quality / code-quality
  • GitHub Check: Analyze (actions)
  • GitHub Check: audit
  • GitHub Check: audit
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: Zizmor
🔇 Additional comments: 1
.github/workflows/publish-worker-v4.yml: 1

95-99: LGTM!

Walkthrough

When the resolved image tag is main, the workflow adds GITHUB_SHA as an additional image tag. Other tags remain unchanged.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to ba5e6

Main-branch supervisor builds will be available under both the mutable main tag and a commit-specific SHA tag, with other tag builds unchanged. No actionable merge risk is identified.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Description check Warning The description clearly explains the change and its scope, but it omits the required issue reference, checklist, testing details, changelog section, and screenshots section. Update the description to include the required template sections. Add the issue reference, complete the checklist, describe testing performed, provide a short changelog entry, and state whether screenshots are applicable.
Passed Passed checks: 4 passed
Check name Status Explanation
Title check Passed The title clearly identifies the CI change: adding a commit-SHA tag to supervisor builds from main.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

Devin Review

Comment thread .github/workflows/publish-worker-v4.yml
@nicktrn
nicktrn added this pull request to the merge queue Oct 14, 2026
Merged via the queue into main with commit 3a1f00b Oct 14, 2026
36 checks passed
@nicktrn
nicktrn deleted the ci/supervisor-sha-tag-on-main branch October 14, 2026 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants