fix(cli): apply extraCACerts on deploy

.changeset/extra-ca-certs-deploy.md

@@ -0,0 +1,5 @@
+---
+"trigger.dev": patch
+---
+
+Fix `extraCACerts` in `trigger.config.ts` having no effect on deployed tasks. The CA file is now included in the deployed image and `NODE_EXTRA_CA_CERTS` points at it, so self-signed or corporate certificates are trusted at runtime.

packages/cli-v3/src/commands/deploy.ts

@@ -50,7 +50,7 @@ import {
 } from "../cli/common.js";
 import { loadConfig } from "../config.js";
 import { authenticateForDeploy, userIdForDeploy } from "../deploy/auth.js";
-import { buildImage } from "../deploy/buildImage.js";
+import { buildImage, resolveExtraCACertsImagePath } from "../deploy/buildImage.js";
 import {
   checkLogsForErrors,
   checkLogsForWarnings,
@@ -765,6 +765,10 @@ async function _deployCommand(dir: string, options: DeployCommandOptions) {
     externalBuildProjectId: deployment.externalBuildData?.projectId,
     projectId: projectClient.id,
     projectRef: resolvedConfig.project,
+    extraCACerts: resolveExtraCACertsImagePath(
+      resolvedConfig.extraCACerts,
+      resolvedConfig.workingDir
+    ),
     apiUrl: projectClient.client.apiURL,
     apiKey: projectClient.client.accessToken!,
     apiClient: projectClient.client,

packages/cli-v3/src/config.ts

@@ -301,6 +301,13 @@ async function autoDetectDirs(workingDir: string): Promise<string[]> {
 }
 
 function validateConfig(config: TriggerConfig, warn = true) {
+  if (config.extraCACerts) {
+    // The CA file must be inside the build output so the image can point NODE_EXTRA_CA_CERTS at it
+    config.build ??= {};
+    config.build.extensions ??= [];
+    config.build.extensions.push(additionalFiles({ files: [config.extraCACerts] }));
+  }
+
   if (config.additionalFiles && config.additionalFiles.length > 0) {
     warn &&
       prettyWarning(

packages/cli-v3/src/deploy/buildImage.test.ts

@@ -10,6 +10,7 @@ import {
   TOOLCHAIN_PACKAGES,
   formatCommandForDiagnostics,
   generateContainerfile,
+  resolveExtraCACertsImagePath,
 } from "./buildImage.js";
 
 describe("formatCommandForDiagnostics", () => {
@@ -53,6 +54,20 @@ const images: Array<[BuildRuntime, string, string]> = [
   ],
 ];
 
+describe("resolveExtraCACertsImagePath", () => {
+  it("returns undefined when no CA file is configured", () => {
+    expect(resolveExtraCACertsImagePath(undefined, "/project")).toBeUndefined();
+  });
+
+  it("maps a project-relative path into /app", () => {
+    expect(resolveExtraCACertsImagePath("./certs/ca.crt", "/project")).toBe("/app/certs/ca.crt");
+  });
+
+  it("strips leading parent segments the same way additionalFiles does", () => {
+    expect(resolveExtraCACertsImagePath("../shared/ca.crt", "/project")).toBe("/app/shared/ca.crt");
+  });
+});
+
 describe("generateContainerfile", () => {
   it.each(images)("uses the pinned published base images for %s", async (runtime, base, build) => {
     const containerfile = await generateContainerfile({

packages/cli-v3/src/deploy/buildImage.ts

@@ -3,7 +3,7 @@ import { depot } from "@depot/cli";
 import { x } from "tinyexec";
 import type { BuildManifest, BuildRuntime } from "@trigger.dev/core/v3/schemas";
 import { networkInterfaces } from "os";
-import { join } from "path";
+import { join, relative, resolve, sep } from "path";
 import { safeReadJSONFile } from "../utilities/fileSystem.js";
 import { readFileSync } from "fs";
 
@@ -55,6 +55,23 @@ export interface BuildImageOptions {
   deploymentSpinner?: any; // Replace 'any' with the actual type if known
 }
 
+/**
+ * Where the CA file ends up inside the image. The build copies it into /app using the same layout
+ * as additionalFiles (path relative to the project root, with leading `..` segments stripped).
+ */
+export function resolveExtraCACertsImagePath(extraCACerts: string | undefined, workingDir: string) {
+  if (!extraCACerts) {
+    return undefined;
+  }
+
+  const relativePath = relative(workingDir, resolve(workingDir, extraCACerts))
+    .split(sep)
+    .filter((segment) => segment !== "..")
+    .join("/");
+
+  return `/app/${relativePath}`;
+}
+
 export async function buildImage(options: BuildImageOptions): Promise<BuildImageResults> {
   const {
     isLocalBuild,