Skip to content

Optimize Node.has_loop using Floyd's cycle detection - #15587

Closed
Aarya1777 wants to merge 1 commit into
TheAlgorithms:masterfrom
Aarya1777:patch-1
Closed

Aarya1777 wants to merge 1 commit into
TheAlgorithms:masterfrom
Aarya1777:patch-1

Conversation

@Aarya1777

@Aarya1777 Aarya1777 commented Oct 17, 2026 •

Copy link
Copy Markdown

Summary

  • Replace the auxiliary-space approach in Node.has_loop with Floyd's tortoise-and-hare cycle detection algorithm.
  • Compare node references using is to detect a cycle.
  • Achieve O(n) time complexity and O(1) auxiliary space.

Testing

  • The existing examples in the docstring cover lists with and without a loop.
  • Tests have not yet been run locally.

Fixes #15576

Refactor has_loop method to use Floyd's Tortoise and Hare algorithm for loop detection.
@algorithms-keeper algorithms-keeper Bot added the awaiting reviews This PR is ready to be reviewed label Oct 17, 2026
@algorithms-keeper

Copy link
Copy Markdown

Closing this pull request as invalid

@Aarya1777, this pull request is being closed as none of the checkboxes have been marked. It is important that you go through the checklist and mark the ones relevant to this pull request. Please read the Contributing guidelines.

If you're facing any problem on how to mark a checkbox, please read the following instructions:

  • Read a point one at a time and think if it is relevant to the pull request or not.
  • If it is, then mark it by putting a x between the square bracket like so: [x]

NOTE: Only [x] is supported so if you have put any other letter or symbol between the brackets, that will be marked as invalid. If that is the case then please open a new pull request with the appropriate changes.

@algorithms-keeper algorithms-keeper Bot removed the awaiting reviews This PR is ready to be reviewed label Oct 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Optimize Node.has_loop to use constant auxiliary space instead of O(N) space

1 participant