Skip to content

Optimize Node.has_loop using Floyd's cycle detection #15587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Aarya1777 wants to merge 1 commit into from
Closed

Optimize Node.has_loop using Floyd's cycle detection #15587

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions data_structures/linked_list/has_loop.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,13 +37,17 @@ def has_loop(self) -> bool:
>>> root_node.has_loop
True
"""
try:
list(self)
return False
except ContainsLoopError:
return True
slow = self
fast = self

while fast is not None and fast.next_node is not None:
slow = slow.next_node
fast = fast.next_node.next_node

if slow is fast:
return True

return False
if __name__ == "__main__":
root_node = Node(1)
root_node.next_node = Node(2)
Expand Down
Loading